memory leak fix #1138
Merged
memory leak fix #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed _function_names and _event_names ContractEvents and ContractFunctions have not used lists _event_names / _function_names. Each time a contract is created through the factory method, the _event_names list and the _function_names list are extended. Creating many contract's results in high memory usage. (cherry picked from commit 94b8b40)
kclowes
approved these changes
Nov 15, 2018
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed _function_names and _event_names
ContractEvents and ContractFunctions have not used lists _event_names / _function_names.
Each time a contract is created through the factory method, the _event_names list and the _function_names list are extended.
Creating many contract's results in high memory usage.
(cherry picked from commit 94b8b40)
What was wrong?
Related to Issue #
How was it fixed?
Cute Animal Picture